shortlr icon indicating copy to clipboard operation
shortlr copied to clipboard

add pagination to /admin/stats page

Open championswimmer opened this issue 8 years ago • 6 comments

this is for frontend. first solve #38 so that the api gives data in pages. then solve this.

championswimmer avatar May 19 '17 17:05 championswimmer

@championswimmer won't infinite scroll be better? As OneAuth also have to get integrated and users will have separate login, we will have to again update the API accordingly.

Infinite Scroll will be just front end work and we will not have to serve multiple pages, though dynamic, to a single user.

0xnmn avatar May 30 '17 11:05 0xnmn

@hereisnaman infinite scroll is nice. But i think the infinite scroll should be backed by an api similar to pagination so that the scroll "streams" data from backend on the fly rather that getting everything at once and then scroll-ify it.

abhishek97 avatar May 30 '17 13:05 abhishek97

@abhishek97 yeah if we need that it pulls content from backend with every load more trigger, rather than pulling all content at once, then arrangements in the API are needed.

Then if we go with that thing, I still, as a user, would like a to have an infinite scroll because I don't want to browse through multiple pages, searching my link.

What you say ?

0xnmn avatar May 30 '17 13:05 0xnmn

@abhishek97 I mean pulling only limited content at once, can we just do it infinite scroll way, than pagination :) ?

0xnmn avatar May 30 '17 14:05 0xnmn

Yes we can make infinite scroll with the current api as well. Let's have an infinite scroll

abhishek97 avatar May 30 '17 14:05 abhishek97

@abhishek97 Great! :)

0xnmn avatar May 30 '17 14:05 0xnmn