ddf icon indicating copy to clipboard operation
ddf copied to clipboard

Support ID query paging

Open derekwilhelm opened this issue 2 years ago • 9 comments

What does this PR do?

Forward port of PR #6737

Who is reviewing it?

@pklinef @clockard

Select relevant component teams:

@codice/solr

Ask 2 committers to review/merge the PR and tag them here.

@glenhein @jlcsmith

How should this be tested?

  1. Ingest or create several metacards
  2. Query the catalog for all of the created metacards by their IDs and set the page size to smaller than the total number of metacards. For example: if there are 10 metacards, set the page size to 5
  3. Verify the first page of results are returned
  4. Adjust the start index to the second page and issue the query again
  5. Verify the second page of results are returned as expected (previously this would be the same list of results as the first query)

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • [ ] Documentation Updated
  • [ ] Update / Add Threat Dragon models
  • [ ] Update / Add Unit Tests
  • [ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

derekwilhelm avatar Jun 02 '23 16:06 derekwilhelm

build now

derekwilhelm avatar Jun 02 '23 16:06 derekwilhelm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Aug 12 '23 05:08 stale[bot]

build now

derekwilhelm avatar Nov 02 '23 23:11 derekwilhelm

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Nov 02 '23 23:11 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Nov 03 '23 01:11 cxddfbot

build now

derekwilhelm avatar Feb 26 '24 15:02 derekwilhelm

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Feb 26 '24 15:02 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Feb 26 '24 17:02 cxddfbot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 06:04 stale[bot]