ddf icon indicating copy to clipboard operation
ddf copied to clipboard

Support default sort parameters for WFS 1.1.0 sources.

Open glenhein opened this issue 2 years ago • 3 comments

What does this PR do?

Support default sort parameters for WFS 1.1.0 sources.

Will add a response property listing the sort property name if it was removed as being unsupported.

Screen Shot 2023-06-05 at 9 02 06 AM

Who is reviewing it?

@derekwilhelm @jlcsmith

How should this be tested?

Configure a WFS source that does not support RELEVANCE. Leave the default sort property and default sort order blank in the config. Confirm that a search that sorts by RELEVANCE returns unsorted results. Change the config to use "name" and "ASCENDING" for the default property and order. Confirm that a search that sorts by RELEVANCE returns results sorted by name.

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • [ ] Documentation Updated
  • [ ] Update / Add Threat Dragon models
  • [ ] Update / Add Unit Tests
  • [ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

glenhein avatar Jun 02 '23 15:06 glenhein

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Jun 07 '23 01:06 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Jun 07 '23 02:06 cxddfbot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Aug 12 '23 05:08 stale[bot]