editor.js icon indicating copy to clipboard operation
editor.js copied to clipboard

Inline toolbar gets recreated on every action used

Open tmclagen opened this issue 1 year ago • 2 comments

Might not be a bug, but a feature.

Whenever you click on any of the available actions inside inline toolbar (i.e. make text bold, italic, underlined, etc) the whole inline toolbar gets recreated. It's smooth and invisible it you don't use any transitions or animations on this toolbar. But if you open the inline toolbar with a bit more ✨fashion✨, then you get some flashing every time you use any of the inline tools.

Steps to reproduce:

  1. Add some transitions to .ce-popover__container (to clearly see the problem)
  2. Type some text
  3. Open inline toolbar by selecting some parts of the text
  4. Use any of the inline tools, for example, make that text bold
  5. See the flashing

Expected behavior:

  1. The whole toolbar doesn't get recreated but instead the state of each button is updated using classes or data attributes?
  2. This will allow us to have entry and leave transitions and animations for the inline toolbar

Video of the bug: https://github.com/user-attachments/assets/ff6be587-b52a-45f8-a8bb-ac3399a35221

OS: Window 11 Browser: Google Chrome 128.0.6613.114 Editor.js version: 2.30.5

tmclagen avatar Sep 01 '24 10:09 tmclagen

@neSpecc @idebenone Can I take a look at this if no one is working on it?

obafemitayor avatar Jan 03 '25 16:01 obafemitayor

@neSpecc @idebenone Can I take a look at this if no one is working on it?

Yes you can!

idebenone avatar Feb 07 '25 09:02 idebenone