editor.js icon indicating copy to clipboard operation
editor.js copied to clipboard

Fixed display of conversion menu for blocks without export rule

Open VolgaIgor opened this issue 1 year ago • 2 comments

Hello! I have fixed the display of conversion menu according to the workflow script from the documentation:

Conversion Toolbar will be shown only near Blocks that specified an «export» rule https://editorjs.io/tools-api/#conversionconfig

Right now the conversion menu is displayed for all blocks, including Image blocks and even Delimiter blocks, which is obviously wrong.

In addition, this user has also had this problem: https://github.com/codex-team/editor.js/issues/2781#issuecomment-2235269544

VolgaIgor avatar Aug 02 '24 12:08 VolgaIgor

@neSpecc @gohabereg @TatianaFomina @ilyamore88 Hello! Can you check the commit, please? I think it's a pretty major visual problem now that the conversion menu is displayed for completely unconvertible blocks. image

VolgaIgor avatar Aug 12 '24 08:08 VolgaIgor

yep, will be great to have the fix merged

gorenburg avatar Aug 14 '24 19:08 gorenburg

any plans on merging this one soon?

gorenburg avatar Sep 09 '24 20:09 gorenburg