editor.js icon indicating copy to clipboard operation
editor.js copied to clipboard

fix: prevent inline toolbar from closing in nested instance of editor

Open gorenburg opened this issue 1 year ago • 2 comments

Based on https://github.com/codex-team/editor.js/pull/2581

Closes issue with inline toolbar being closed in the nested editor instance when clicking on the toolbar button with some actions. The fix is taken from https://github.com/codex-team/editor.js/pull/2581; this PR adds cypress tests for the fix

gorenburg avatar Jul 17 '24 14:07 gorenburg

There is an ESLint error:

/home/runner/work/editor.js/editor.js/test/cypress/support/utils/nestedEditorInstance.ts
   1:1   error    All imports in the declaration are only used as types. Use `import type`  @typescript-eslint/consistent-type-imports

neSpecc avatar Aug 14 '24 19:08 neSpecc

There is an ESLint error:

/home/runner/work/editor.js/editor.js/test/cypress/support/utils/nestedEditorInstance.ts
   1:1   error    All imports in the declaration are only used as types. Use `import type`  @typescript-eslint/consistent-type-imports

was fixing it the same moment you added comment 😄

gorenburg avatar Aug 14 '24 19:08 gorenburg

Ready to ship? 😀

gorenburg avatar Sep 13 '24 21:09 gorenburg