muse icon indicating copy to clipboard operation
muse copied to clipboard
verified publisher icon codetheweb

feat: automatically turn volume down when people talks

Open xytxxx opened this issue 1 year ago • 1 comments

This PR introduces a new feature that automatically lowers the music volume when users in the voice channel are speaking. The feature can be turned on/off through environment variables (default is off), and the target volume of when people are talking is also configurable (default is 70%).

Tested in personal Discord and found 70% volume leads to subtly better experience.

  • [✓] I updated the changelog

xytxxx avatar Sep 15 '24 21:09 xytxxx

:package: :robot: A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1096.

Images are available for x86_64 and ARM64.

Latest commit: 33aefef8df528c798c35b77587cd2c30ffad9102

codetheweb avatar Sep 15 '24 21:09 codetheweb

@Hazzajenko Would you be able to test and confirm this feature still works?

Xeravax avatar Oct 30 '24 20:10 Xeravax

@Hazzajenko Would you be able to test and confirm this feature still works?

Sure I'll have a look after work today

Hazzajenko avatar Oct 31 '24 00:10 Hazzajenko

I've updated the volume reduction feature to align with the standard approach of addons in muse:

  • Removed the environment variables (TURN_DOWN_VOLUME_WHEN_PEOPLE_SPEAK and TURN_DOWN_VOLUME_WHEN_PEOPLE_SPEAK_TARGET) in favor of Discord slash commands
  • Added two new config commands:
    • /config set-reduce-vol-when-voice to toggle the feature
    • /config set-reduce-vol-when-voice-target to set the reduction percentage (0-100)
  • Settings are now stored in Prisma DB like other bot configurations

Hazzajenko avatar Nov 01 '24 06:11 Hazzajenko

LGTM

Xeravax avatar Nov 04 '24 12:11 Xeravax

🚀 Released in Release v2.10.0.

codetheweb avatar Nov 04 '24 14:11 codetheweb