muse icon indicating copy to clipboard operation
muse copied to clipboard

Feat: allow users to change dotenv file with env var

Open JoaoCostaIFG opened this issue 1 year ago • 3 comments

This facilitates the usage of docker secrets for the keys/tokens.

For example on a docker-compose.yml file:

muse:
  image: codetheweb/muse:latest
  container_name: muse
  secrets:
    - muse_env
  environment:
    - ENV_FILE=/run/secrets/muse_env
  restart: unless-stopped
  
secrets:
  muse_env:
    file: /usr/local/etc/muse_env

See relevant dotenv doc

  • [ ] I updated the changelog

JoaoCostaIFG avatar Jul 06 '24 00:07 JoaoCostaIFG

Not sure if I should update the changelog. Please let me know.

JoaoCostaIFG avatar Jul 06 '24 00:07 JoaoCostaIFG

:package: A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-1040 or codetheweb/muse:3d7a85843fc4c8028ac87a0e5df98c477f2fffc1.

Images are available for x86_64 and ARM64.

Latest commit: 3d7a85843fc4c8028ac87a0e5df98c477f2fffc1

github-actions[bot] avatar Jul 06 '24 00:07 github-actions[bot]

Cool!

  1. Let's default ENV_FILE to /config in the Dockerfile so there's a sensible default.
  2. We should also document this in the README.

Thank you!

codetheweb avatar Jul 18 '24 04:07 codetheweb

@JoaoCostaIFG Do you still want this PR to be processed?

Xeravax avatar Oct 28 '24 15:10 Xeravax

@JoaoCostaIFG Do you still want this PR to be processed?

I haven't been using discord, so I completely forgot about this PR. Sorry about that. I just pushed the requested changes. Let me know if there's anything else that needs work.

JoaoCostaIFG avatar Oct 28 '24 16:10 JoaoCostaIFG

:package: :robot: A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1040.

Images are available for x86_64 and ARM64.

Latest commit: d5cec6048be79f395688f67e799f1385779cbe69

codetheweb avatar Oct 28 '24 16:10 codetheweb

LGTM

Xeravax avatar Oct 29 '24 08:10 Xeravax

🚀 Released in Release v2.9.5.

codetheweb avatar Oct 29 '24 09:10 codetheweb