react-d3-components icon indicating copy to clipboard operation
react-d3-components copied to clipboard

Adding line at an index-number

Open martinbkure opened this issue 10 years ago • 8 comments

Hi,

really interesting component.

This is purely meant as a question/add-on.

I have a small request/question.

Is it possible to indicate an index-number that will create a straight line running through the graph. Like the image below:

graph

Regards

Martin

martinbkure avatar Sep 18 '15 11:09 martinbkure

I am working on making the components work more easily with other components, like layering them etc. Then it should be easy to add such a line given you have access to the d3 scales.

codesuki avatar Sep 24 '15 05:09 codesuki

Hi, that'll be great. love the component and the effort you put into it.

martinbkure avatar Sep 24 '15 07:09 martinbkure

Thanks! I wish I had more time for it :)

codesuki avatar Sep 24 '15 08:09 codesuki

Here is an example of layering graphs: https://codesuki.github.io/react-d3-components/transitions/index.html

The same way it should be possible to layer a line on top. I will try to release the layering without the transition support first, since transitions will still take more time.

codesuki avatar Oct 01 '15 06:10 codesuki

Looks excellent. Bravo. :-)

martinbkure avatar Oct 01 '15 07:10 martinbkure

@codesuki Is there a code sample for that link in the repo? I only see a webpack'd version. I'm looking to do this too and would like to see can I at least get a hack going :D

mcdonnelldean avatar Dec 15 '15 12:12 mcdonnelldean

@mcdonnelldean sorry I thought I replied here. I am writing an email to you now.

codesuki avatar Jan 05 '16 09:01 codesuki

@codesuki Epic Looking forward to it.

mcdonnelldean avatar Jan 05 '16 09:01 mcdonnelldean