Olli

Results 41 comments of Olli

Thanks for your feedback. I rebased (and squashed) the branch ontop of the main branch. > mypy-pyqt5 failing: This can be fixed via guarding the relevant code in if machinery.IS_QT6:...

@The-Compiler, this works only without type annotations. As soon as I add type annotations for the `request` or the `state` arguments (e. g. `request: QWebEngineWebAuthUxRequest`), I get this test failure:...

After rebasing onto main, finally all checks are successful.

Thanks for testing, @pachungulo. > I noticed a lack of prompt to touch the security key in cases without user verification. This is far from needed but it's something other...

> > I have however encountered a crash when aborting on pinentry. To reproduce, go to webauthn.io, get prompted to enter your Yubikey PIN, and abort. > > I can...

@The-Compiler, there are currently no tests for prompts except as part of the download functionality. Do you expect me to add anything in that regard? Otherwise this PR is complete.

> There still are various unresolved comments from the last review, however. @The-Compiler, I went through all open comments and don’t see anything that wouldn’t be resolved. Do you want...

> Huh? None of the comments displayed currently at https://github.com/qutebrowser/qutebrowser/pull/8642/files seem to be resolved, e.g.: > […] Oh, I missed these comments as they are not appearing in the Conversations...

> After some more testing, I encountered a crash when unplugging the yubikey during both PIN prompt and when prompted to touch the device. I attached the dump below. It...

I addressed the remaining issues and rebased it ontop of the main branch. Is there anything left that prevents this PR from being accepted?