bounty icon indicating copy to clipboard operation
bounty copied to clipboard

Added dirty way of setting what the result should be AFTER the spinni…

Open travisryan opened this issue 2 years ago • 3 comments

created a dirty way of being able to start the spinning and then set the result later. After running the setTo function, it basically restarts the spinning 3 seconds in (so the slow rampup won't be done again) and then finishes with the new result. I'd love to see this done in a better way.

travisryan avatar Jun 01 '23 15:06 travisryan

Ok figured out how to run two of them at the same time. Nevermind that part...

travisryan avatar Jun 01 '23 17:06 travisryan

Added the option to have noBlur for browsers without hardware acceleration. Must be specified on the start of the program.

travisryan avatar Jun 02 '23 16:06 travisryan

Hey @travisryan , First of all Thanks for the effort! Unfortunately the code quality need to be significantly improved before we can go further.

please follow those guidelines:

  • code changes should be related to the PR title and description (so no extension to other parts)
  • please keep high coding standards in examples (no inline js on DOM etc)
  • Don’t leave unnecessary comments
  • Don’t leave console logs (also commented ones)
  • If there is an api change, it should be documented in readme and the best another example should be created (instead of changing the default one)
  • Let’s rethink public api (startFinish sounds vague )

Thanks!

coderitual avatar Jun 03 '23 14:06 coderitual