laravisit icon indicating copy to clipboard operation
laravisit copied to clipboard
verified publisher icon coderflexx

scopePopularAllTime and scopePopularBetween modification

Open mainadennis opened this issue 3 years ago • 3 comments

  1. Inside the scopePopularAllTime() I added a whereHas('visits) to only fetch records that has been visited, initially it was returning all records including those without visits.
  2. Inside the scopePopularBetween(), I added an orderBy clause to get the records in descending order starting with that with the highest visit count. This is helpful in case the user only needs one result that has highest visit count.

mainadennis avatar Jul 19 '22 08:07 mainadennis

Hello, @mainadennis

Sorry for the late response.

It seems some tests failed, can you run the tests in your end, and see what's wrong exactly!

Thanks for your time/PR.

ousid avatar Aug 11 '22 23:08 ousid

Hello @ousid The tests seems to be failing due to a composer plugin not from the pull request, here's a message from all the failing tests "Error: pestphp/pest-plugin contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe."

mainadennis avatar Aug 12 '22 15:08 mainadennis

Hey, @mainadennis.

The codebase has been update, consider to pull the latest changes, and try again.

Thanks!

ousid avatar Aug 14 '22 21:08 ousid