Mingw support?
Will there any potential future support for mingw-w64 go/windows native (not wsl)? I'm not exactly sure how sshcode and go work so I'm sorry if this is a dumb question
Right now we only support remote linux environments, I imagine we'd probably support starting sshcode remotely in a docker container before we support native windows since that's more platform-agnostic
If it's docker then that's fine
The PR https://github.com/cdr/sshcode/pull/118 has code that supports Windows with MINGW.
I will be re-submitting this code as soon as https://github.com/cdr/sshcode/pull/121 gets merged.
I have made a PR with some rather basic mingw/msys support. only as the user though, not the server https://github.com/cdr/sshcode/pull/127
What this does is allow sshcode to run inside a msys client, for example
$ sshcode.exe --skipsync [email protected] will open a sshcode session as if you were running on linux
The code in #124 should work. I haven't had the time to address the comments in order to get it merged yet.
@eargollo Wanna combine your changes to mine? https://github.com/Merith-TK/sshcode {branch msys-support}
Your changes are for the windows filepath conversion, mine are for getting chrome support. (from what i see atleast)
Sure thing. Let's do it. Do you want me to merge your changes there? How do you want to do it?
Well, saying our changes make it so the lines wont like up just right, i think we would have to find the diff between our branches and manually add them.
I have added you as a Collaborator to my repo
@eargollo I have applied my code into yours (offline at the moment) and it does execute properly
What i dont fully understand is why your sshcode.go has only (with my code added in) 432 lines of code, and mine has 573?
I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself.
mayeb yours is slightly out of date? and when i run the merged code, it
still works, it turns out i dont know how to use the filepath to open
/home/$USERNAME/workspace
—Merith
On Wed, Jul 31, 2019 at 9:05 AM Eduardo Argollo [email protected] wrote:
I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cdr/sshcode/issues/94?email_source=notifications&email_token=ACPQOXVUX3F6TGIQGTOOZ43QCGZ53A5CNFSM4HLEWMU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HX6KQ#issuecomment-516914986, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPQOXWBQEVCJZRKT2O2UZLQCGZ53ANCNFSM4HLEWMUQ .
Please discuss PR specific stuff in one of the relevant PRs.
quesiton is, which PR do we discuss on? Mine #127 or his #124 ?