add shellcheck to ci for linting scripts

Open matifali opened this issue 2 years ago • 1 comments

We already have shfmt it would be nice to also lint using shellcheck.

@mafredri I would appreciate it if you could do this sometimes. It's not a high priority, just something we should do at some point.

Feb 07 '24 18:02 matifali

This came up in https://github.com/coder/modules/pull/297#discussion_r1778858754

Assigning this to me now so I don't lose track.

Sep 27 '24 19:09 mafredri

Posted a proposal in https://github.com/coder/modules/issues/331#issuecomment-2437730678 that would allow us shellcheck both library code (lib.sh) and the main shell code (run.sh). This issue is currently pending whether or not we go forward with this approach.

Oct 25 '24 14:10 mafredri