code-server icon indicating copy to clipboard operation
code-server copied to clipboard

[Bug]: Failed to resolve the callback address of the identity verification plugin.

Open ZXiangQAQ opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

OS/Web Information

  • code-server --version: 4.19.1 0c98611e6b43803a9d5dba222d7023b569abfb49 with Code 1.84.2

Steps to Reproduce

Expected

authentication success

Actual

I have a personal authentication plugin. When the authentication is successful and it returns to vscode-server, there was a failure in parsing the callback address. All parameters of the callback address are encoded as a whole, but during parsing, the parameters are first obtained and then decoded, resulting in authentication failure for the callback.

Unable to duplicate lines in vscode, vscode authentication is normal.

Logs

No response

Screenshot/Video

468022d10f9915d76607cdedae457d19

Does this issue happen in VS Code or GitHub Codespaces?

  • [X] I cannot reproduce this in VS Code.
  • [X] I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over a secure context?

  • [X] I am using a secure context.

Notes

No response

ZXiangQAQ avatar Dec 13 '23 11:12 ZXiangQAQ

Interesting, if it works in Codespaces then we must be messing up the encoding somewhere. But I am not sure where we would be doing this.

code-asher avatar Dec 15 '23 20:12 code-asher