code-server icon indicating copy to clipboard operation
code-server copied to clipboard

Use theme colors on login page, error pages, and VS Code page before it loads

Open nooobcoder opened this issue 4 years ago • 16 comments

  • [ ] Grab VS Code theme colors and use those
    • [ ] Login page
    • [ ] Error pages
    • [ ] VS Code page (before it loads, to avoid the flash)
  • [ ] When theme colors are not available use system setting for light/dark
  • [ ] Possibly a toggle for light/dark mode

nooobcoder avatar Apr 02 '21 02:04 nooobcoder

Maybe we could use the same theme VS Code is using? That could be cool.

code-asher avatar Apr 02 '21 15:04 code-asher

@code-asher what about the shades of purple theme? https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple

The color scheme is so good, maybe code-server should use it by default. Just a recommendation.

nooobcoder avatar Apr 03 '21 03:04 nooobcoder

@jsjoeio @code-asher can I expect this feature in the next release 3.9.4 I am skipping updating to 3.9.3 as I could not see any major changes in code-server.

nooobcoder avatar Apr 11 '21 12:04 nooobcoder

We don't have this on the 3.9.4 milestone; I think it's unlikely we'll get to it soon.

code-asher avatar Apr 12 '21 16:04 code-asher

Echoing Asher, this is a lower priority for us. We also have some changes happening across our internal/external projects, which would be related to this. cc @vapurrmaid

jsjoeio avatar Apr 12 '21 19:04 jsjoeio

Echoing Asher, this is a lower priority for us. We also have some changes happening across our internal/external projects, which would be related to this. cc @vapurrmaid

Hey @jsjoeio - yea, I think this is more likely to land June or during the summer months thereafter, as our internal design system is being built out in our April and May iterations. This exact ticket and code-server is one of the first uses-cases I have in mind and am building for as an acceptance state for our design system.

greyscaled avatar Apr 12 '21 22:04 greyscaled

Hello, any news on this ? Thanks

KaKi87 avatar Sep 11 '21 15:09 KaKi87

@KaKi87 not yet. It's still lower priority, but feel free to chime in with any thoughts around why this is important to you and what you'd like to see.

jsjoeio avatar Sep 13 '21 16:09 jsjoeio

I have an update: as of the September release of Coder, we've internally started on a design system and we've implemented theming in-product. While the design system is not fully fleshed out, it brings us one step closer to being able to achieve this ticket with the design system.

greyscaled avatar Sep 13 '21 16:09 greyscaled

feel free to chime in with any thoughts around why this is important to you and what you'd like to see

More than anything, I would like to have a dark mode on it, even if it's a separate setting from VSCode, even if it's not following the theme's color code, although I would appreciate that too. 🙂

KaKi87 avatar Sep 14 '21 07:09 KaKi87

Dark mode would be awesome! Thanks for adding that. We'll add more updates as we have them like @vapurrmaid said so keep an eye on this issue!

jsjoeio avatar Sep 14 '21 17:09 jsjoeio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

stale[bot] avatar Mar 13 '22 17:03 stale[bot]

Here's activity occuring.

KaKi87 avatar Mar 13 '22 17:03 KaKi87

I request a feature for a customizable login screen in this discussion #5569. I will mark it as answered and hope for future progress in this issue.

LaCocoRoco avatar Sep 19 '22 18:09 LaCocoRoco

In the meantime, for Dark Reader users, I created a Dark Reader dynamic blacklist userscript that, among other things, toggles Dark Reader on/off depending on routes for websites & webapps with incomplete theming.

I just added code-server support, which means the userscript will disable Dark Reader on any instance, except on login screens.

As you can see in the following screenshots, Dark Reader is enabled on both pages, but only affects the login page, and not the project page.

Login page Project page
Screenshot from 2023-02-01 05-34-54 Screenshot from 2023-02-01 05-34-28

I'm still looking forward to the login page adopting the user theme.

Thanks

KaKi87 avatar Feb 01 '23 04:02 KaKi87