Karen Attfield
Karen Attfield
This PR is currently waiting on next steps from the Zap team.
Thanks for the thorough testing here @darssen, really much appreciated. > I was not able to see the link when tabbing towards the contact form. But there is no regression...
Thanks for reporting this! It looks like the issue is not due to changing layout as such, but occurs when transforming the block from a Slideshow block to Tiled Gallery...
Thanks @jsnajdr for mentioning that. I'm better off reverting the changes in this PR for now as that needs more investigating.
So it turns out the issue is that on P2, since we're editing on the front-end, the extra details aren't available due to us fetching only site icon and title...
Adding to the public data worked for P2, but not for Simple front-end. I'm looking into how that could work. Edit - approach is here: https://github.com/Automattic/jetpack/pull/44072
At the moment just awaiting https://github.com/Automattic/jetpack/pull/39696, but anyone can manually update the A4A plugin readme 'tested to' in a separate PR as needed if it tests well and I can...
@rcanepa @jkguidaven apologies, I missed the earlier question. The 'updated to' version was updated for all plugins once this PR was merged. Vulcan doesn't release any plugins, but Garage does...
Thanks both for testing! @monsieur-z can you share any more about your Simple site setup and how you are testing if you can still replicate? In my case for example,...
Thanks @darssen ! Following up separately about the Classic Theme Helper plugin testing instructions, I've removed these now as it looks like more work is needed on that plugin, so...