smiley
smiley
I've added the missing PHPCS scripts. Heads-up: PHPCBF "conveniently" changes all line endings from CRLF to LF on Windows (not helpful).
Hey, I am aware of this issue (https://wiki.php.net/rfc/deprecate-implicitly-nullable-types). PHP 8.4 is a couple more months down the road, implicit nullables will be fixed until then.
Just as a heads-up, this is what currently happens when I enable PHP 8.4 on CI: https://github.com/chillerlan/php-settings-container/actions/runs/9947535033/job/27480365765 (spoiler: countless warnings from dev-dependencies)
@campbell-m I've pushed a fix to address this issue to the v4 and v5 as well as dev-main (upcoming v6) branches. Can you perhaps check if this resolves the issue...
I'm going to reopen this as this is probably not done yet. It's still not possible to run tests on CI under PHP 8.4 as dependencies will cause trouble.
PHP 8.4 GA release is next week - if anything explodes in the meantime it's not my fault... 🤞
> Sounds like Phan was raising a false positive PhanParamSignatureRealMismatchReturnType error It might have been and is perhaps fixed in the meantime. However, the issue with incompatible return types in...
So this is more of an issue for your web front end then? Then again, I'd assume if you define an `url` property here, it would be up to said...
Thank you for the explanation! > The assumption of a pattern of https://bsky.app/profile//post// isn't even a written down spec, although the team have stated it's very unlikely to change because...