rust-ocpp icon indicating copy to clipboard operation
rust-ocpp copied to clipboard

Added prelude.rs for both v1_6 and v2_0_1 (Used in tests)

Open hlsxx opened this issue 9 months ago • 9 comments

I’m suggesting this PR because I believe using preludes can be helpful in certain scenarios, including mine 🙂

I’ve also updated tests/schema_validation to reflect how these preludes are used—hope you find it useful!

use crate::v2_0_1::datatypes::prelude::*;
use crate::v2_0_1::enumerations::prelude::*;
use crate::v2_0_1::messages::prelude::*;

hlsxx avatar May 07 '25 12:05 hlsxx

Nice! Will approve in a couple of days. Need to spend some time on #165 right now

tommymalmqvist avatar May 07 '25 19:05 tommymalmqvist

Sure, man!

hlsxx avatar May 08 '25 14:05 hlsxx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.99%. Comparing base (bc60955) to head (5d20ee3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         189      189           
  Lines       31464    31464           
=======================================
  Hits        29576    29576           
  Misses       1888     1888           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 20 '25 19:05 codecov[bot]

Want to add support for the new v2_1? @hlsxx

tommymalmqvist avatar May 20 '25 19:05 tommymalmqvist

Sure, I'd be happy to.

hlsxx avatar May 21 '25 05:05 hlsxx

Sure, I'd be happy to.

Build is failing

tommymalmqvist avatar May 21 '25 12:05 tommymalmqvist

Sure, I'd be happy to.

Build is failing

Sure, I'd be happy to.

Build is failing

I'm not done yet, I just commit some changes but I will work on that today or tomorrow ;)

hlsxx avatar May 21 '25 13:05 hlsxx

Sure, I'd be happy to.

Build is failing

Sure, I'd be happy to.

Build is failing

I'm not done yet, I just commit some changes but I will work on that today or tomorrow ;)

Just checking 😅

tommymalmqvist avatar May 21 '25 13:05 tommymalmqvist

Okey, I'm done now :) ready for review and merge

hlsxx avatar May 22 '25 06:05 hlsxx