codelab icon indicating copy to clipboard operation
codelab copied to clipboard

Update depency injection milestone with providedIn: 'root'

Open kirjs opened this issue 6 years ago • 4 comments

Right now we only mention including service in a module and never mention using "providedIn: root". We should update info to reflect this future.

https://codelab.fun/angular/dependency-injection/provide-injectable

the code is in apps/codelab/src/app/codelabs/angular/dependency-injection/dependency-injection.component.html

kirjs avatar Sep 06 '19 00:09 kirjs

Should we replace including service in a module with "providedIn: root" option or just to add one more slide referencing that?

aintnomoreloyalty avatar Sep 29 '19 12:09 aintnomoreloyalty

I already looked at what's in codelab, you can safely change everything to providedIn: 'root'.

And we have to discuss about another cases in another issue.

thekiba avatar Sep 29 '19 12:09 thekiba

Cool, thanks I'm gonna work on this 👩🏻‍💻

aintnomoreloyalty avatar Sep 29 '19 12:09 aintnomoreloyalty

I'd say just update the slides in a way you think makes sense for you and then let's have a call and think of the best way to explain it?

NothingEverHappens avatar Sep 30 '19 11:09 NothingEverHappens