CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

Bug: The Validation::run() method does not match the ValidationInterface.

Open iRedds opened this issue 3 years ago • 5 comments

CodeIgniter4 Version

4.2.1

What happened?

Missing $dbGroup argument.

https://github.com/codeigniter4/CodeIgniter4/blob/7439b6ec5134492bbbf466d99bc206aa883a4b54/system/Validation/Validation.php#L109

https://github.com/codeigniter4/CodeIgniter4/blob/7439b6ec5134492bbbf466d99bc206aa883a4b54/system/Validation/ValidationInterface.php#L28

iRedds avatar Jul 03 '22 03:07 iRedds

It does not seem to be an error. https://3v4l.org/U59Qp

kenjis avatar Jul 03 '22 07:07 kenjis

Do you have any specific problems on this mismatch?

kenjis avatar Jul 03 '22 07:07 kenjis

No problem. But it seems to me that the meaning in the declaration of the interface is lost if the class that implements it is different.

iRedds avatar Jul 03 '22 08:07 iRedds

In this case, it seems that updating the run() method in the ValidationInterface in version 5 would solve the problem.

Or try to change the interface in 4.3?

kenjis avatar Jul 04 '22 07:07 kenjis

I don't know how to get out of this situation. I thought that the team would find the optimal solution.

iRedds avatar Jul 04 '22 07:07 iRedds

Closed by #6253

kenjis avatar Sep 07 '22 22:09 kenjis