CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

Allow for custom exception handlers.

Open lonnieezell opened this issue 3 years ago • 2 comments

Allows developers to easily create and integrate their own Exception handler classes, and limiting their usage to only the exception or HTTP status code desired.

Supercedes #5355

Checklist:

  • [x] Securely signed commits
  • [x] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [x] User guide updated
  • [x] Conforms to style guide

lonnieezell avatar Feb 10 '22 06:02 lonnieezell

This is more then I can handle on mobile, but looks really good! On my "to do" list.

MGatner avatar Feb 11 '22 01:02 MGatner

It seems to me that this PR is BC. Services::exceptions() returns an instance of the CodeIgniter\Debug\Exceptions class, which can be extended. Changing this class will cause breaking changes for the custom implementation.

Yeah, you're correct. I have been sick the last couple of days but needed to do something other than sleep for a few hours and wasn't up to tackling the refactor of Tasks needed to get it integrated into the framework so I figured I could knock this out. Obviously wasn't thinking 100%.

We can shelve it or start a 5.0 branch so it doesn't just clog up the PR lists, or something.

lonnieezell avatar Feb 11 '22 14:02 lonnieezell

Any update on this PR?

gphg avatar Feb 27 '23 04:02 gphg

I have updated this PR for 4.4, and it is waiting for reviews. #7087

kenjis avatar Feb 27 '23 06:02 kenjis

Closed by #7087

kenjis avatar Apr 09 '23 23:04 kenjis