plexus-utils icon indicating copy to clipboard operation
plexus-utils copied to clipboard

Use Path in the Scanner API

Open laeubi opened this issue 3 years ago • 4 comments

This would be a minimal change to move the API of Scanner to the Path API

This could be some kind of minimal change that could be merged as base for larger changes like:

  • https://github.com/codehaus-plexus/plexus-utils/pull/225

laeubi avatar Nov 24 '22 06:11 laeubi

@olamy could this be a first step?

laeubi avatar Nov 24 '22 06:11 laeubi

Also look at https://github.com/apache/maven-shared-utils/pull/54. IMHO we should only implement in one library....

kwin avatar Jan 05 '23 14:01 kwin

Also look at apache/maven-shared-utils#54. IMHO we should only implement in one library....

The most notable thing I see is that it is two years old now and no progress at all...

laeubi avatar Jan 05 '23 14:01 laeubi

I'm a bit skeptical about breaking the API and replacing the return type of the getBasedir(). A less problematic approach would be to provide a different method which would return a Path instead, or a new interface if we want to avoid having both File and Path in the same interface (the implementation could implement both interface, provided they use different names for the conflicting methods).

gnodet avatar May 16 '23 21:05 gnodet