Adrian Cole
Adrian Cole
fyi 0.9.0 is out cc @mtwo this sorts out some of the recent propagation issues
FWIW the throwable isn't lost in Brave. It is just that this implementation loses it. There's a `SpanHandler` in brave made specifically for the case of parsing throwables. That no...
there are two issues here, btw. The SpanKind maps exactly to Brave, this can be fixed The error labels do not indicate they must be a Throwable, so this is...
Some other things that can be done.. based on the description of error, one of them can be the RPC status, which we have a field for > "rpc.error_code", eg...
Thanks @fzakaria. honestly the mapping isn't that tight it says literally: > /error/message | An error message. "Rendezvous of RPC that terminated with: status = StatusCode.UNAVAILABLE details = OS Error."...
technically you are right.. we (I) didn't spend any time going back to discuss v1 in the spec, hoping people stop using it :) anyway I will put some notes...
ps you don't need to default port to 0.. unless I had a brain cramp I thought I said please don't default it to zero :D On Tue, Oct 9,...
https://github.com/openzipkin/zipkin-api/pull/54 for v1 I'll just make the change directly to v2 as only 2 fields are required though it would be silly to only serialize traceId, spanId
oops v2 format already says so.. ``` required: - traceId - id ```
It is about querying by duration in the UI. Ex traces longer than 10s On 18 Apr 2017 5:45 pm, "Jordi Polo Carres" wrote: > You mean that instrumentation needs...