Adrian Cole

Results 2050 comments of Adrian Cole

the general tradeoff is this: - at the cost of time (ex large brown fields like twitter won't be able to flip switch to 128bit until finagle updates to at...

added #6 for tracking library updates to 128bit

in brave, we ensure the sampling bits are assigned when debug is, even if they weren't propagated. This means that outgoing would have both sampled and debug even if sampled...

There's a number of ways to accomplish this. ### Specify the X-B3-TraceId and X-B3-SpanId headers In B3, the recipient of `X-B3-TraceId` and `X-B3-SpanId` resumes that span, even if they immediately...

I didn't mention my opinion on returning X-B3-TraceId.. something I should have. First, the audience for this project are hopefully less than 50 developers of tracing libraries, not end-users. Long...

ex this is a swagger decorator which allows power-users a way to initiate traces, using B3 without knowing how it works https://github.com/Yelp/swagger_zipkin by @prat0318

Ah cool just pinged you on account of commit volume to envoy (also assumed some x-twitter folks might be implicated in envoy and may have known about B3) On 16...

here's an example of "option 2" which is used by jaeger by @yurishkuro https://github.com/uber/jaeger-client-java/pull/53

> @adriancole https://github.com/adriancole could the B3 docs state that > it's an application concern whether or not the trace ID is returned in the > response? i.e. it's not part...

> @adriancole https://github.com/adriancole totally understood on wanting > to avoid situations that generate timewasting questions, especially on > something that doesn't need to be (or shouldn't be) part of the...