Adrian Cole

Results 2050 comments of Adrian Cole

@nonspecialist mind having a crack at fixing this?

I wouldn't interpret Flags 0 in any way except for the same as unset

In other libraries we are being conservative by default and allowing users an api to change the default tags (on request, response and error). This is because stack traces can...

Usually we let PRs come in response to user demand.. are you a user? Regardless, something like this if done in a way safe to the codebase could be helpful...

> > Trying to become one; see #198 (comment) > > > thanks! > if the code was pluggable and allows for revisions to the spec to not > break...

@sphinxy wondering if you have cycles to help support the project. this is an example of a problem that needs some help

probably we should prefer user agent formatting right? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent ``` User-Agent: / Common format for web browsers: User-Agent: Mozilla/ () () ``` Ex here's FF actually sending during this issue...

cc @openzipkin/core preferences on agent format?

first thought seems probably the format is less like user agent and more like content-type. also we have this in the url path... On Fri, Jul 12, 2019 at 4:14...

> zipkin/2.1.0 zipkin-reporter-okhttp3/2.9.3 > > I like the second part. I'm not sure what the first part represents. Is that the Zipkin Server version? zipkin core library version. It might...