Adrian Cole

Results 2046 comments of Adrian Cole

ps another reason why this probably went unnoticed might be the scenario you described as going from http -> https. Since feign is usually used for apis, I suspect most...

Sorry.. I was on the plane when trying to comment to most of this, just catching up in detail now. It looks like you want to "convert [a 3xx error]...

@sbuettner which part of same problem? :) are you having a redirect from http->https? Can you put a failing test or an example of request/response so we can make the...

@sbuettner sorry I really need you to be specific. Is your goal to decode a 3xx response? Why is it the case that when redirects are exhausted the result is...

IOTW, "http status codes >= 300 are handled as an error" isn't clarifying what your goal is, it is just describing the roadblock. Here's are some examples, with some precanned...

ps in case it isn't clear, I'm in favor of adding `RedirectHandler` which could have two impls, a `Decoder` impl, which treats 3xx range as success, and `ErrorDecoder` impl, which...

Well to be clear, I just don't want to widen the interface of decoder, as I don't think we should place redirect range responsibility on jackson, gson, etc. Any solution...

We should be returning Response unconditionally. I agree with that being a bug.

ps. wow.. embarrassingly we have no redirect tests here or even in denominator. Changing the following line in `SynchronousMethodHandler` passes all tests ``` - if (response.status() >= 200 && response.status()...