Adrian Cole

Results 2050 comments of Adrian Cole

probably hopelessly out of date, but if you are bored and want to rebase, I'll try it!

@shakuzen I'd go for RABBIT_SSL_ENABLED if it works for PCF as it can defer the more difficult options to later. It is hard to foresee configuration all providers might need...

hi JC so this is http specific, so in addition to the endpoint details. When talking about a tag usually we dont have interdependencies such as this flag means interpret...

> > @adriancole I should have been more > clear. I meant that having a flag in the options of the middleware that > says recordHost: true|false so user could...

We've recently had this concern again in Brave, where client-side host/authority tag could be handy https://github.com/openzipkin/brave/issues/950 I'd kind of like to just land this soon as it seems most agree...

To punt a specific plan of action. 👍 this comment if you want the following. reply back if you want something different instead! define "server.host" tag with only the host...

pasting this seems to work: "test:debug": "react-scripts --inspect-brk test --runInBand --no-cache", then.. `npm run test:debug -- src/zipkin/span-node.test.js` see https://create-react-app.dev/docs/debugging-tests/

@mrajah-twttr want to give a try at first PR by trying these instructions, then adding to lens README?

thanks for raising this. you aren't the first. I think the impl will be the key in annotationQuery from the http api. This can either be a tag key or...

I'm starting to wonder if an indexconfig type wouldn't be helpful, because right now, we have the following indexes: * serviceName * spanName * remoteServiceName * annotations (non-core implicitly, ex...