Adrian Cole comments

Results 2050 comments of


                                            Adrian Cole

Migrate to Brave 6 and Zipkin Reporter 3

red looks unrelated unless I'm missing something

Migrate to Brave 6 and Zipkin Reporter 3

rebased. let me know what else is needed here!

Migrate to Brave 6 and Zipkin Reporter 3

same snapshot download error as before..

Migrate to Brave 6 and Zipkin Reporter 3

thanks @mhalbritter .. one less thing on my nag list, but more importantly a big step forward for those using this stuff. cheers!

Default SpringBootTest to "spring.main.banner-mode=off"

> I deactivate the banner for my test profile in the configuration. yep while every project can do this, the request is about if this can be made default, so...

Default SpringBootTest to "spring.main.banner-mode=off"

thanks, empty banner was the trick we didn't think about. cheers! https://github.com/openzipkin/zipkin/pull/3734

Implement HttpClient based Zipkin sender

this is great. looking forward to the removal of the other senders!

Updated Spark to 3.x, Scala to 2.12 and ElasticSearch to 7.13.x

thanks a lot!

Use Runtime.getRuntime().totalMemory() to calculate 1% of the heap memory

This default value was made for a simple default, and the sizing is imprecise for sure. I don't expect we'll want the complexity to try for precise sizing, neither try...

Update docker image openzipkin/zipkin-dependencies:latest (2.6.3) on Docker Hub and GitHub Container Registry

latest version is 3.0.0 and deployed to docker hub and ghcr.io supporting ES 7.x and 8.x