Adrian Cole
Adrian Cole
If we choose to support quoted json client-side, let's keep scope down. opentracing has tags (which map to binary annotations) and the new thing is that annotations might be a...
ps added more rationale here, hoping people resist the temptation to pollute zipkin with stringified json cc opentracing advocate @basvanbeek https://github.com/openzipkin/openzipkin.github.io/issues/52#issuecomment-249749327
@eirslett elasticsearch queries specialize in natural json fields. they cannot navigate into quoted json naturally. For example, the following two json: ``` json { "timestamp": 1474934400200000, "value": "{\n \"type\": \"error\",\n...
Ex. I know of no syntax to navigate into quoted json, like `value.kind:"client"` Maybe there's a "fuzzy json" mechanism I'm not aware of..
@eirslett I think I answered the wrong question :) You aren't asking about how to query annotations in json using elasticsearch, you are asking about when you are tracing elasticsearch...
IMHO definitely we need to render binary annotation values properly as json (ex arbitrary levels of nesting). This was a feature that existed before. On how to render keys (ex...
sounds like you are asking for a sidecar, so that you can configure your application to report to localhost, right?
depending on lack of feedback to the contrary, [this issue](https://github.com/openzipkin/zipkin/issues/3605) may change things on this PR, as the idea is changing to the default ES client. If change happens like...
@ankit-gautam23 @snower so what I understand here is that the type of tags is incorrect, for example, the value isn't a string, rather something else. So, I am guessing that...
ps I will help with the test backfill on current code, as I think it will lead to resolving this one way or another more easy. In some ways this...