Adrian Cole
Adrian Cole
ok I set current versions and also added a missing test about what this is all about, basically that there are no class problems in indirect deps
fyi new toys for those using the deps in question https://github.com/openzipkin/zipkin-reporter-java/releases/tag/3.3.0
so I assume we don't need this PR anymore as basically the change is removing armeria-brave and adding the package-info to deprecate brave5?
fwiw latency is a guess because the distance between "cs" and "sr" is hardly a signal compared to the resource timing api used in chrome https://www.w3.org/TR/resource-timing/#resources-included that said, using annotations...
looks nice! actually it calls out that we probably don't want the primary duration label as "response time" since it isn't necessarily that. While not everyone logs it, it might...
We should be careful about line and breakout count for a top-level readme. We already explain how to submit the job in two ways. More importantly, I'm not sure this...
This relates to https://github.com/openzipkin/zipkin-java/issues/215 except this one is just an unimplemented feature. Right now, I've been manually making commits like 919d8b5c9ab5e7751695084a3a943d32663b47fc, and these could be automated. cc @abesto
you are very likely going to need a more recent version of node. have you tried installing via ./mvnw clean install? This pins the version of node iirc