Adrian Cole

Results 2050 comments of Adrian Cole

usually we don't add reporters for transports that have no collectors. this leads to an incomplete feature story and possibly code maintained for only one user or site. can you...

ok probably if adding a collector, forking (and raising a pull request) on zipkin-gcp could be a nice route. the cloud function idea is also neat. I think span consumption...

@javierviera I just raised this issue https://github.com/openzipkin/zipkin-gcp/issues/132

cc @kojilin @jplock @marcingrzejszczak @nicmunroe

Whether or not we can read the parameters, is it not about the invocation of a java method? We do use the word invocation to describe the trace context at...

regardless good point to ensure we can handle lambda based @anuraaga. This should be in a unit test and drive the model requirements. I suspect aspectj etc also have some...

> Don't think I understand the question. But invoking a Java method requires both the definition (Class / Method) and parameters. There is only one method in an app but...

PS sorry I did write `Span.invocation(Class clazz, Method method)` which was not my intention to say that would be the final signature.. rather to get thoughts going. I think I...

> Also, how does this relate to #999? Will we still have RpcRequest? RpcRequest is not always associated with a Java method (ex incoming proto service) ```java * The unqualified,...

@johnament you know me.. rule-of-three :) can you help make this more popular? maybe see if users of CDI are interested and can comment back that they's use it?