Adrian Cole
Adrian Cole
@mathetake PTAL I think we are good. I'm not going to make a full on bench for gojs right now as already way over time budget and there is too...
One thing I noticed, but won't dig into at the moment, is this has no ability to collaborate with ad-hoc JavaScript at the moment (ex define ad-hoc functions in JS...
The other thing left out is that Go allows via .s files the ability to import custom functions. This was left out as the calling convention Go uses is completely...
I guess what we are really talking about here is externalizing the compilation cache. plus possibly some guard to make sure if the structure of the code changes the cache...
@F21 I think you already have an issues about `InstantiateModule()` https://github.com/tetratelabs/wazero/issues/602 which is unrelated to this because Compile happens before that. Just setting expectations.
thanks for the feedback folks, this is great. don't worry too much about issue classification as we can sort it out.
ack we need to look at existing VMs and how they do bytecode validation and to what degree this applies to us. Especially we shouldn't commit to a serialization mechanic...
good points, @clarkmcc. I also don't believe a commit hash approach would work unless stable tags are in use (ex monthly tags starting end of august), and even then I...
To be transparent about current thinking and to not block others doing it :) First, if someone can profile what's taking the longest for their code, if possible, as there...
Another aspect related would be memory imports, though I suspect these are more likely to be understood as unsafe as they are always multi-word (page size is 64K)