vscode-rpgle icon indicating copy to clipboard operation
vscode-rpgle copied to clipboard
verified publisher icon codefori

Fix(getIncludeFromDirective): ignore the comment line

Open sebCIL opened this issue 1 year ago • 2 comments

Changes

/include or /copy does not work if there is a comment on the line.

Checklist

  • [X] have tested my change
  • [X] updated relevant documentation
  • [X] Remove any/all console.logs I added
  • [ ] eslint is not complaining
  • [X] have added myself to the contributors' list in the README
  • [X] for feature PRs: PR only includes one feature enhancement.

sebCIL avatar Oct 22 '24 11:10 sebCIL

@sebCIL Can you provide a test case for this?

worksofliam avatar Oct 28 '24 15:10 worksofliam

I'm not sure where to put the test... I have made a modification

sebCIL avatar Oct 28 '24 16:10 sebCIL

is it ok ?

sebCIL avatar Nov 27 '24 08:11 sebCIL

@sebCIL Sorry for the delay. I will look this week!

worksofliam avatar Nov 27 '24 14:11 worksofliam

@sebCIL I made one blank new line - thanks for the test case! Let's merge!

worksofliam avatar Dec 02 '24 13:12 worksofliam