Add a job browser

[sebCIL]

Changes

On response at the idea : "Job browser #304." That's the first step.

• Add 2 types of liste : My job and all job with subsystem expandable.
• Add the posibilities to a job :
  • End
  • Change
  • Hold
  • Release
  • Display Joblog

The next step is adding the capability to add a custom filter like Object Browser.

Checklist

• [X] have tested my change
• [ ] updated relevant documentation
• [X] Remove any/all console.logs I added
• [ ] eslint is not complaining
• [X] have added myself to the contributors' list in CONTRIBUTING.md
• [ ] for feature PRs: PR only includes one feature enhancement.

[worksofliam]

@sebCIL This is very cool! I need to do a larger review of the code and functionality. That I will do over this weekend. Thanks!

[sebCIL]

I stay tuned if there are improvements to make or bugs to correct.

[sebCIL]

Ok, I made a lot of changes to make it more in line with the initial request. I hope it will be suitable.

[worksofliam]

@sebCIL great, thanks! I won't be able to review until this weekend or maybe even next week.

@chrjorgensen if you wanted, you're more than welcome to review (also, if I'm bugging you too much then just let me know).

[worksofliam]

@sebCIL Is this ready for a review again?

[sebCIL]

Okay, I made the requested changes.

[sebCIL]

@worksofliam did you do the review? Do I need to make any other changes?

[worksofliam]

@sebCIL no review yet, sorry. Been busy with other things, but it will be soon!

[sebCIL]

@worksofliam Ok, I made the changes.

[worksofliam]

@sebCIL Review will be done this weekend.

[sebCIL]

I think it was OK.

I add the job status on the description.

[sebCIL]

Should I add a condition to load this view only if SQL is enable (in order to protect it from crash)?

Maybe in Instance.js, something like that :

if (config.enableSQL) {
  context.subscriptions.push(
    vscode.window.registerTreeDataProvider(
      `jobBrowser`,
      new jobBrowser(context)
    )
  );
}

Let me know ...

[worksofliam]

@sebCIL Yes, that's a good condition to add!

[sebCIL]

Done.

[worksofliam]

@sebCIL I will get a review done later today, thanks!

The job browser will be the start of something much larger - the 'admin' portion. When I have reviewed and merged, we are going to move the Job Browser into its own panel. The 'IBM i Admin' panel which will be disabled by default, will provide system maintenance type functionality - much like your job browser.

I am trying to draw a clear line between development and admin type work, and moving it into a separate view will help with that.

[worksofliam]

@sebCIL If you wouldn't mind fixing the conflict, that would be great.

[worksofliam]

@sebCIL Thought I'd give you an update. I am happy with this PR, but am holding off while I figure out if this belongs in the base of the extension before I go put in the work to put all the 'admin' type functionality (like this PR) into a separate extension.

Thanks!

[sebCIL]

Thank you for the news. Ok. Let me know if I can help on the 'admin' extension.

[worksofliam]

@sebCIL Ok, there is finally a plan.

The 'admin' extension, which is really just a way to edit objects right now, will be used to host the job browser and eventually the spool file browser.

https://github.com/halcyon-tech/vscode-ibmi-fs

All this work should eventually be ported as a PR over there. That extension is in the early days and we are using a different UI framework, so building the commands you have here will likely work a little different.

[sebCIL]

Thank you for this feedback. I'll look into it.