vscode-ibmi icon indicating copy to clipboard operation
vscode-ibmi copied to clipboard
verified publisher icon codefori

Simplify IBMi class

Open krethan opened this issue 1 year ago • 3 comments

Changes

Introducing new classes to help simplify logic in IBMiSettings class.

How to test this PR

Examples:

  1. Run the test cases
  2. Expand view A and right click on the node
  3. Run 'Execute Thing' from the command palette

Checklist

  • [* ] have tested my change
  • [ ] have created one or more test cases
  • [ ] updated relevant documentation
  • [ ] Remove any/all console.logs I added
  • [* ] have added myself to the contributors' list in CONTRIBUTING.md

krethan avatar Oct 02 '24 05:10 krethan

Okay sending for another review.

krethan avatar Oct 13 '24 03:10 krethan

@krethan I should give a warning that there is another PR being worked on which separates the UI logic from the backend logic in the IBM i class. That may have to come before this.

worksofliam avatar Oct 22 '24 21:10 worksofliam

Thanks for the heads up

krethan avatar Oct 24 '24 01:10 krethan

@krethan That happened and the frontend logic is no longer tied into the backend. Sorry for the trouble!

worksofliam avatar Jan 25 '25 18:01 worksofliam