vscode-ibmi icon indicating copy to clipboard operation
vscode-ibmi copied to clipboard
verified publisher icon codefori

Use interfaces instead of classes for type checking

Open sebjulliand opened this issue 1 year ago • 0 comments

Changes

Fixes https://github.com/IBM/vscode-ibmi-projectexplorer/issues/422 (cc @edmundreinhardt)

The parameter types for the code-for-ibmi.downloadMemberAsFile command were recently changed to BrowserItem type, which prevented other extensions from using it without passing an object of this type.

By changing the expected type to ObjectItem | MemberItem, it allows other extensions to use this command again.

How to test this PR

  1. Download a member from the Object Explorer
  2. Download a member from the Project Explorer Library List node.

Checklist

  • [x] have tested my change

sebjulliand avatar Mar 27 '24 10:03 sebjulliand