botium-core icon indicating copy to clipboard operation
botium-core copied to clipboard

#831 Fix issue with long numbers in Capabilities being updated to a different number

Open abhilashkasula opened this issue 3 months ago • 4 comments

Pull Request addresses Issue/Bug:

What issue/bug is addressed by this pull request ? #831

Implemented behaviour:

What did you actually change ?

  • Updated the code to check isFinite for newCaps instead of caps as the number would have already changed in caps due to JSON.parse.
  • Added a test to validate this change

Build successful?

Is build still possible ? ("npm run build") Yes

Unit Tests changed/added:

Have unit tests been changed or added to reflect new functionality ? Yes

abhilashkasula avatar Oct 31 '25 12:10 abhilashkasula

@codeforequity-at Could you review this PR?

abhilashkasula avatar Nov 04 '25 10:11 abhilashkasula

@codeforequity-at This is blocking us in our testing. Could you review this quickly?

abhilashkasula avatar Nov 12 '25 02:11 abhilashkasula

there is a branch conflict pls resolve @abhilashkasula

codeforequity-at avatar Nov 17 '25 09:11 codeforequity-at

@codeforequity-at updated the PR. Please review now.

abhilashkasula avatar Dec 02 '25 18:12 abhilashkasula