codecov-action
codecov-action copied to clipboard
codecov
fail_ci_if_error not respected during verification
Description
The fail_ci_if_error input is not respected during uploader verification.
This line hardcodes the failure status:
...
} catch (err) {
setFailure(`Codecov: Error validating uploader: ${err.message}`, true);
}
As you can see, using true to set the failure status does not account for whether fail_ci_if_error is disabled.
Resolution
This call site for should be changed to match similar call sites like this one.
Would you be willing to accept a PR that injects the failCi boolean as a parameter to the verify function?
Related Issues
- https://github.com/codecov/codecov-action/issues/286
- https://github.com/pulumi/pulumi/issues/9730
