codecov-action
codecov-action copied to clipboard
Error during upload doesn't fail action
The action fails with the messages
warning - 2024-03-21 14:32:57,088 -- No config file could be found. Ignoring config.
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
but the step is actually shown as "successful" in the github interface. It would be good to actually fail in case there is an error.
Example: https://github.com/apollo-server-integrations/apollo-server-integration-h3/actions/runs/8376730386/job/22937079972?pr=51
Just enable the fail_ci_if_error option, coz by default it is false.
This is a bad default, I would opt for changing it to true, or inverting the flag.