CodeceptJS icon indicating copy to clipboard operation
CodeceptJS copied to clipboard

fix: error message of dontSeeCookie

Open a-stankevich opened this issue 1 year ago • 1 comments

Motivation/Description of the PR

  • Description of this PR, which problem it solves The error message reported for 'dontSeeCookie' was copy-pasted from 'seeCookie', while it should be the opposite. The only helper with correct message is TestCafe, so wording from there is applied to other helpers.
  • Resolves #issueId (if applicable).

Applicable helpers:

  • [x] Nightmare
  • [x] Playwright
  • [x] Puppeteer
  • [x] WebDriver

Applicable plugins:

  • [ ] allure
  • [ ] autoDelay
  • [ ] autoLogin
  • [ ] customLocator
  • [ ] pauseOnFail
  • [ ] coverage
  • [ ] retryFailedStep
  • [ ] screenshotOnFail
  • [ ] selenoid
  • [ ] stepByStepReport
  • [ ] stepTimeout
  • [ ] wdio
  • [ ] subtitles

Type of change

  • [ ] :fire: Breaking changes
  • [ ] :rocket: New functionality
  • [x] :bug: Bug fix
  • [ ] 🧹 Chore
  • [ ] :clipboard: Documentation changes/updates
  • [ ] :hotsprings: Hot fix
  • [ ] :hammer: Markdown files fix - not related to source code
  • [ ] :nail_care: Polish code

Checklist:

  • [ ] Tests have been added
  • [ ] Documentation has been added (Run npm run docs)
  • [x] Lint checking (Run npm run lint)
  • [x] Local tests are passed (Run npm test)

a-stankevich avatar May 21 '24 10:05 a-stankevich

I'm not sure if we should have this change. As the error message is from here already indicated not. https://github.com/codeceptjs/CodeceptJS/blob/0e1b86af238ca648f1fbd0964d42abb3d969dc81/lib/assert.js#L63

kobenguyent avatar May 21 '24 11:05 kobenguyent

hm, what would be the best way to have the correct error message then? currently it's like this: image

a-stankevich avatar May 22 '24 13:05 a-stankevich

Oh, I think I understand. I've removed 'not' where negate is used

a-stankevich avatar May 22 '24 14:05 a-stankevich

@a-stankevich I saw you also mentioned WebDriver, but don't see the changes there. May you check?

kobenguyent avatar May 29 '24 09:05 kobenguyent

@a-stankevich I saw you also mentioned WebDriver, but don't see the changes there. May you check?

Those changes were done by mistake and have been reverted. I've unchecked related checkboxes now

a-stankevich avatar May 29 '24 11:05 a-stankevich