node-mac-contacts icon indicating copy to clipboard operation
node-mac-contacts copied to clipboard
verified publisher icon codebytere

Merge upstream?

Open maccman opened this issue 5 years ago • 2 comments

There are a ton of enhancements in this branch (Catalina support, promises etc) - just putting them on your radar in case you want to merge upstream.

https://github.com/lefooey/node-mac-contacts

maccman avatar Oct 18 '20 02:10 maccman

@maccman oh interesting 👀 I'm not sure i'll take on all those changes (e.g i'd rather not return a promise for getAuthStatus probably) but there's some error handling & efficiency improvements in there i can absolutely incorporate.

Thanks for bringing this to my attention!

codebytere avatar Oct 18 '20 17:10 codebytere

@lefooey would you be interested in upstreaming any of the enhancements you've made?

codebytere avatar Oct 18 '20 17:10 codebytere