Shelley Vohr
Shelley Vohr
@sami-azzam i found this: https://developer.apple.com/forums/thread/737391 i'm not sure what our next steps are but i can poke at it.
oh fun, one more issue - not with the docs though! Looks like your change surfaced an actual types issue in `lib/browser/api/browser-window.ts` - we need to add a check for...
We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action....
We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action....
Small lint issue: ``` $ node ./script/lint.js && npm run lint:docs shell/browser/electron_browser_client.cc:463: (cpplint) If/else bodies with multiple statements require braces [readability/braces] [4] Total errors found: 1 ```
@clavin is there any more work to be done here or can this be merged?
@rmnbrd good news! This was an upstream issue fixed in https://issues.chromium.org/issues/327027138. I can try to backport it but it's in versions v30.0.0-beta.1 and newer.
Fixed in https://github.com/electron/electron/pull/41889
[Bug]: Electron main process crash during any navigator.serial requests on MacOS in development mode
I ran the repro and could not reproduce the issue. it logs `Serial port open request` to console and does not crash. Beyond that, the verbiage in the above comment:...
I'm not able to reproduce this behavior; it looks as expected on 27.0.3: