backend icon indicating copy to clipboard operation
backend copied to clipboard

[User Registration][Testing] New Registration & Auth Flow Broke "Users" App Tests

Open BethanyG opened this issue 5 years ago • 4 comments

The changes in PR #187 once merged will cause the tests under users/tests/ to mostly fail (6 out of 9).

Currently, these are marked skip, but need to be re-written to work (or the app needs to change to make them work).

Failing tests are:

 -   users/tests/test_models.py:7 test_user_get_absolute_url
 -   users/tests/test_urls.py:8 test_detail
 -   users/tests/test_urls.py:16 test_update
 -   users/tests/test_urls.py:21 test_redirect
 -   users/tests/test_views.py:19 TestUserUpdateView.test_get_success_url
 -   users/tests/test_views.py:43 TestUserRedirectView.test_get_redirect_url

Suspect they can mostly be fixed with some URL changes. Since the "users" app is largely unused due to DRF, these were seen as lower-priority tests, and I didn't hold #187 for them.

BethanyG avatar Sep 24 '20 07:09 BethanyG

One overarching question here is do we even want this as an endpoint?? userauth has all of the registration flow and email verifications, should we just add to it for the user profile, or park that functionality here in users??

BethanyG avatar Sep 25 '20 00:09 BethanyG

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 25 '20 02:10 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 25 '20 18:11 stale[bot]

still open

BethanyG avatar Nov 25 '20 18:11 BethanyG