data-structures-algorithms-python icon indicating copy to clipboard operation
data-structures-algorithms-python copied to clipboard

Binary search exercise solution could be further optimized

Open Kimonili opened this issue 5 years ago • 1 comments

Instead of linearly searching for all the occurrences we could do that faster by searching them all in a binary way.

Here:

while i >=0:
    if numbers[i] == number_to_find:
        indices.append(i)
    else:
        break
    i = i - 1

And here:

while i<len(numbers):
    if numbers[i] == number_to_find:
        indices.append(i)
    else:
        break
    i = i + 1

I would be happy to make a pull request 😄

PS: Your tutorial playlist on DSA is amazing!

Kimonili avatar Jan 15 '21 13:01 Kimonili

thanks bhai jan

Muhammad-ismail786 avatar Aug 17 '25 00:08 Muhammad-ismail786