daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

bug: Pagination option present in both top and bottom

Open DeepanshuMishraa opened this issue 1 year ago • 4 comments

Title: The Pagination button is both on the appbar as well in the bottom of a particular track

Steps to reproduce the behavior:

  1. Open a particular track and scroll to bottom of it

Expected behavior Pagination option should only be either on top or bottom

Screenshots or GIFs image

  • Browser : Chrome

Additional context I don't know if it's intentional but there should be only one option for pagination either on the top or bottom

DeepanshuMishraa avatar Aug 18 '24 17:08 DeepanshuMishraa

hi @DeepanshuMishraa ,[Pagination button at bottom] change I can suggest here in when we arrive at the bottom of track the top pagination can be hidden.

karthik-nair-20 avatar Aug 18 '24 17:08 karthik-nair-20

Good point, but UX-wise, having two pagination buttons isn't good I guess. We can scroll back up to paginate, so one button is enough. Multiple buttons can add clutter and redundancy.

DeepanshuMishraa avatar Aug 18 '24 17:08 DeepanshuMishraa

It was intentional guys. I forgot the reason. Would love if you can get a pr with something good.

devsargam avatar Aug 18 '24 18:08 devsargam

oh , got it i thought it was some kind of mistake

DeepanshuMishraa avatar Aug 18 '24 18:08 DeepanshuMishraa

@devsargam this is issue is resolved in my PR

keshav-exe avatar Aug 19 '24 03:08 keshav-exe

Thanks for clarifying @keshav-exe

devsargam avatar Aug 19 '24 05:08 devsargam

Fixed

devsargam avatar Aug 26 '24 19:08 devsargam