daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard
verified publisher icon code100x

ui changes

Open keshav-exe opened this issue 1 year ago • 2 comments

PR Fixes:

  • 1 UI Upgrade
  • 2 Fixed Categorisation & Added "Cohort 2.0" & "Cohort 3.0"

Resolves #527 #530 #531

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

Screenshot

keshav-exe avatar Aug 15 '24 13:08 keshav-exe

LGTM, merging this after all other PR's are merged.

devsargam avatar Aug 16 '24 10:08 devsargam

cool, thanks!

keshav-exe avatar Aug 16 '24 11:08 keshav-exe

@keshav-exe could you share more screenshots on all the changes that you made, want to avoid making any changes involving them. btw ui looks sick

nischal-shetty2 avatar Aug 19 '24 08:08 nischal-shetty2

@devsargam @hkirat

What's Changed:

  • Dynamic Metadata for slides
  • Updated Notion Renderer (font, background, code block, copy buttons, and ofc animated)
  • fixed sizings from previous commit

localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-4 localhost_3000_auth_callbackUrl=http2F3A3000%2F localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-2 localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-2 (1)

keshav-exe avatar Aug 21 '24 02:08 keshav-exe

@devsargam @hkirat please check this for Notion Renderer redesign: #555

ItsFlash10 avatar Aug 21 '24 06:08 ItsFlash10

@devsargam fixed the issues we discussed.

keshav-exe avatar Aug 21 '24 14:08 keshav-exe

Your design looks great sir. Only problem that I can see is getting this error when clicking the download button

image

devsargam avatar Aug 24 '24 18:08 devsargam

looking into it

keshav-exe avatar Aug 25 '24 01:08 keshav-exe

@devsargam fixed it please take a look

keshav-exe avatar Aug 25 '24 08:08 keshav-exe

This got a lot of merge conflicts Tryingt o fix locally

hkirat avatar Aug 26 '24 15:08 hkirat

This got a lot of merge conflicts Tryingt o fix locally

I have resolved the conflicts in my PR maybe you can have a look #555

ItsFlash10 avatar Aug 26 '24 15:08 ItsFlash10

This got a lot of merge conflicts Tryingt o fix locally

I have resolved the conflicts in my PR maybe you can have a look #555

Just saw you closed it, actually there were only 7odd file changes in my PR for Notion renderer changes but since #532 wasn't merge and I needed the new design I created the branch from @keshav-exe's ui-redesign branch so those files are there in the diff too :)

ItsFlash10 avatar Aug 26 '24 15:08 ItsFlash10

Moved changes to https://github.com/code100x/daily-code/pull/572/ , resolved conflicts there

hkirat avatar Aug 26 '24 16:08 hkirat