daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

Fix: Scrollbar is not visible in light mode

Open karananeja opened this issue 1 year ago • 7 comments

PR Fixes:

  • 1 Scroll bar color is updated for light mode to make it more visible

Resolves #[Issue Number if there] #240

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

karananeja avatar Apr 14 '24 13:04 karananeja

there is lot of unwanted new lines , you can remove that , and try this code , : just replace these

/* Scroll Bar */
::-webkit-scrollbar {
	width: 10px;
}

::-webkit-scrollbar-thumb {
  background-color: rgb(0, 0, 0);
  border-radius: 8px;
}

vishalmishraa avatar Apr 14 '24 21:04 vishalmishraa

Too much noise in the PR

hkirat avatar Apr 14 '24 22:04 hkirat

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat Didn't understand, what do you mean by noise?

karananeja avatar Apr 15 '24 04:04 karananeja

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat Didn't understand, what do you mean by noise?

Remove comments from the code

iamgauravbisht avatar Apr 16 '24 02:04 iamgauravbisht

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat Didn't understand, what do you mean by noise?

Remove comments from the code

@iamgauravbisht done

karananeja avatar Apr 16 '24 17:04 karananeja

@karananeja this has been fixed i guess.

mumin-khan avatar Apr 29 '24 13:04 mumin-khan

@mumin-khan I think it's not fixed yet.

karananeja avatar Apr 30 '24 08:04 karananeja