cms icon indicating copy to clipboard operation
cms copied to clipboard

(BUG) Major Signin Form validation and ux bug

Open VineeTagarwaL-code opened this issue 1 year ago • 5 comments

Bug:

The signin form has few issues with it mentioned below :

  1. No proper validation was setup instead just error signin is shown
  2. no loader or a proper loading state to show the progress of the login process
  3. lacks the good ux as well as ui
  4. it doesn't gets the value from auto-fill feature from password manager

To Reproduce

Steps to reproduce the behavior 1 :

  1. Go to signup page and input for e.g. hello.com and then click on signin
  2. toast appears

Steps to reproduce the behavior 2 :

  1. Go to signup page and input something and then click on signin
  2. No way for user to understand if the request actually went through, there should be something that shows the loading state

Steps to reproduce the behavior 4 :

  1. Go to signup page and if there is autofill click on signin
  2. see that the values being there, it shows required error

Expected behavior

  1. proper validation of input when the buttons get clicked
  2. loading state for better ux
  3. autofill values acceptance
  4. better ux

Screenshots or GIFs autofill error image wrong validation handling image

Info (please complete the following information):

  • Browser [chrome, firefox]
  • Version [e.g. 124.0.1]

Additional context i have a pr below attached that fixes all these errors

VineeTagarwaL-code avatar Apr 11 '24 17:04 VineeTagarwaL-code

@hkirat pleae let me know what needs to be changed

VineeTagarwaL-code avatar Apr 11 '24 17:04 VineeTagarwaL-code

Do you really think, it's a real issue? @VineeTagarwaL-code, can't see some big change rather adding form

image

zssssssf avatar Apr 12 '24 16:04 zssssssf

please go through the issues i mentioned #373 again

VineeTagarwaL-code avatar Apr 12 '24 19:04 VineeTagarwaL-code

Yes I have gone theough the issue and your changes seems minor not major but good work

zssssssf avatar Apr 12 '24 19:04 zssssssf

if you have checked the pr convo, the major part was about the validation of and ux ..... i fixed both of them but the email validation was not that much needed so found a round way solution for that and made the changes, @devsargam also approved it so ig its good to go

VineeTagarwaL-code avatar Apr 12 '24 19:04 VineeTagarwaL-code