(BUG) Major Signin Form validation and ux bug
Bug:
The signin form has few issues with it mentioned below :
- No proper validation was setup instead just
error signinis shown - no loader or a proper loading state to show the progress of the login process
- lacks the good ux as well as ui
- it doesn't gets the value from auto-fill feature from password manager
To Reproduce
Steps to reproduce the behavior 1 :
- Go to signup page and input for e.g. hello.com and then click on signin
- toast appears
Steps to reproduce the behavior 2 :
- Go to signup page and input something and then click on signin
- No way for user to understand if the request actually went through, there should be something that shows the loading state
Steps to reproduce the behavior 4 :
- Go to signup page and if there is autofill click on signin
- see that the values being there, it shows required error
Expected behavior
- proper validation of input when the buttons get clicked
- loading state for better ux
- autofill values acceptance
- better ux
Screenshots or GIFs
autofill error
wrong validation handling
Info (please complete the following information):
- Browser [chrome, firefox]
- Version [e.g. 124.0.1]
Additional context i have a pr below attached that fixes all these errors
@hkirat pleae let me know what needs to be changed
Do you really think, it's a real issue? @VineeTagarwaL-code, can't see some big change rather adding form
please go through the issues i mentioned #373 again
Yes I have gone theough the issue and your changes seems minor not major but good work
if you have checked the pr convo, the major part was about the validation of and ux ..... i fixed both of them but the email validation was not that much needed so found a round way solution for that and made the changes, @devsargam also approved it so ig its good to go