cms icon indicating copy to clipboard operation
cms copied to clipboard

Fix: Keybindings Interference Between Video Player and Comments

Open Aayuslad opened this issue 1 year ago • 1 comments

PR Fixes:

  • Fixing the issue of keybindings interference between the video player and comments.

Resolves #364

Description:

This PR addresses an issue where keyboard shortcuts used in the comment textarea were affecting the video player's behavior. The problem occurred when certain keys, such as < or >, were pressed while typing comments, causing unintended effects on the video playback speed.

To resolve this issue, I added event handling to prevent the propagation of keyboard events when typing in the comment textarea.

This change ensures that keyboard shortcuts are properly isolated to the comment input area, providing a smoother user experience without interfering with the video playback.

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding the same issue

https://github.com/code100x/cms/assets/111479342/f526a7cd-b23a-4619-ab6f-086e913751d5

Aayuslad avatar Apr 11 '24 10:04 Aayuslad

There is already a PR for this issue created #365

Devmanwani avatar Apr 11 '24 15:04 Devmanwani

/bounty $5

hkirat avatar Apr 12 '24 11:04 hkirat